]> git.apps.os.sepia.ceph.com Git - ceph-ansible.git/commit
UCA: Uncomment UCA variables in defaults, fix consequent breakage
authorMatthew Vernon <mv3@sanger.ac.uk>
Wed, 27 Mar 2019 13:34:47 +0000 (13:34 +0000)
committermergify[bot] <mergify[bot]@users.noreply.github.com>
Tue, 9 Apr 2019 16:54:37 +0000 (16:54 +0000)
commita8c9b65d1348b4ee54ff2d68d41ef002d544d246
tree0cfb5769d16d00a921280756d23b5c1d966d2c85
parentefa0083f3c3f598b2d0fde5343beadc61469f1ff
UCA: Uncomment UCA variables in defaults, fix consequent breakage

The Ubuntu Cloud Archive-related (UCA) defaults in
roles/ceph-defaults/defaults/main.yml were commented out, which means
if you set `ceph_repository` to "uca", you get undefined variable
errors, e.g.

```
The task includes an option with an undefined variable. The error was: 'ceph_stable_repo_uca' is undefined

The error appears to have been in '/nfs/users/nfs_m/mv3/software/ceph-ansible/roles/ceph-common/tasks/installs/debian_uca_repository.yml': line 6, column 3, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

- name: add ubuntu cloud archive repository
  ^ here

```

Unfortunately, uncommenting these results in some other breakage,
because further roles were written that use the fact of
`ceph_stable_release_uca` being defined as a proxy for "we're using
UCA", so try and install packages from the bionic-updates/queens
release, for example, which doesn't work. So there are a few `apt` tasks
that need modifying to not use `ceph_stable_release_uca` unless
`ceph_origin` is `repository` and `ceph_repository` is `uca`.

Closes: #3475
Signed-off-by: Matthew Vernon <mv3@sanger.ac.uk>
(cherry picked from commit 9dd913cf8a3dcc12683b55ae13d95bca6f15cd32)
group_vars/all.yml.sample
group_vars/rhcs.yml.sample
roles/ceph-common/tasks/installs/install_debian_packages.yml
roles/ceph-defaults/defaults/main.yml
roles/ceph-mds/tasks/non_containerized.yml
roles/ceph-mgr/tasks/pre_requisite.yml