]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Explicitly mark destructors with override (#13212) v9.10.0
authorAndrew Chang <andrewrchang@meta.com>
Mon, 16 Dec 2024 19:17:27 +0000 (11:17 -0800)
committerAndrew Chang <andrewrchang@meta.com>
Mon, 16 Dec 2024 20:45:14 +0000 (12:45 -0800)
commitae8fb3e5000e46d8d4c9dbf3a36019c0aaceebff
treefcefaefeedaaae3aa7bf01239ea35b3286b7469e
parent6e8dc7455b6b02db903a452db7178a183c272c8a
Explicitly mark destructors with override (#13212)

Summary:
I saw these compiler warnings while preparing for the 9.10 release:

```cpp
'~CompactOnDeletionCollectorFactory' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]

'~CompactForTieringCollectorFactory' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
```

This code is from a while ago so I assume that this CI check has been failing for quite some time. We should still clean this up to avoid confusion in the future.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/13212

Test Plan: Existing CI checks should pass, and we should not see this CI check failure the next time we try to make a release/patch.

Reviewed By: jaykorean

Differential Revision: D67287794

Pulled By: archang19

fbshipit-source-id: a11230a919c0b7ef21a7219bf05f567d3d44b2d1
include/rocksdb/utilities/table_properties_collectors.h