]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
common/ip_addr: do not support numa preference if WITH_SEASTAR
authorKefu Chai <kchai@redhat.com>
Mon, 14 Jan 2019 10:08:03 +0000 (18:08 +0800)
committerYingxin Cheng <yingxincheng@gmail.com>
Tue, 15 Jan 2019 04:05:47 +0000 (12:05 +0800)
commitaf23895dba85e23586a7bc2aee544fa8575d4514
tree2cbf3a205948b74aeb414ccfeeef0a3ebc348501
parenteb683a3a2a890211a29fd1af4a0fc01d7138f76d
common/ip_addr: do not support numa preference if WITH_SEASTAR

in pick_address.cc, set_val_or_die() is called to set the "public_addr"
and/or "cluster_addr". but since the sharded ConfigProxy cannot
set_val_or_die() synchronously, we cannot do it this way.

we need to fix pick_addresses() so it works with seastar later. either
by making the involved function return future<>, or making the set_val()
call non-blocking or synchronous if we can go with 1:1 mapping
threading model.

but at this moment, let's just disable this feature in crimson-osd.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/common/ipaddr.cc