]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Do not create/install new SuperVersion if nothing was deleted during memtable trim...
authorLevi Tamasi <ltamasi@fb.com>
Fri, 13 Dec 2019 20:45:49 +0000 (12:45 -0800)
committerLevi Tamasi <ltamasi@fb.com>
Fri, 10 Jan 2020 17:53:31 +0000 (09:53 -0800)
commitafbfb3f56783a0ce426a7af06898e2178f7b2694
tree9bc26a9671aa77b37d0f5923fe6bb7f38a7ce9ab
parent4cfbd87afd08a16df28436fb990ef6b154ee6114
Do not create/install new SuperVersion if nothing was deleted during memtable trim (#6169)

Summary:
We have observed an increase in CPU load caused by frequent calls to
`ColumnFamilyData::InstallSuperVersion` from `DBImpl::TrimMemtableHistory`
when using `max_write_buffer_size_to_maintain` to limit the amount of
memtable history maintained for transaction conflict checking. As it turns out,
this is caused by the code creating and installing a new `SuperVersion` even if
no memtables were actually trimmed. The patch adds a check to avoid this.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6169

Test Plan:
Compared `perf` output for

```
./db_bench -benchmarks=randomtransaction -optimistic_transaction_db=1 -statistics -stats_interval_seconds=1 -duration=90 -num=500000 --max_write_buffer_size_to_maintain=16000000 --transaction_set_snapshot=1 --threads=32
```

before and after the change. With the fix, the call chain `rocksdb::DBImpl::TrimMemtableHistory` ->
`rocksdb::ColumnFamilyData::InstallSuperVersion` -> `rocksdb::ThreadLocalPtr::StaticMeta::Scrape`
no longer registers in the `perf` report.

Differential Revision: D19031509

Pulled By: ltamasi

fbshipit-source-id: 02686fce594e5b50eba0710e4b28a9b808c8aa20
db/db_impl/db_impl_write.cc