]> git-server-git.apps.pok.os.sepia.ceph.com Git - teuthology.git/commit
task/install: extra_system_packages at the top level can be a list
authorIlya Dryomov <idryomov@gmail.com>
Tue, 4 Nov 2025 12:02:46 +0000 (13:02 +0100)
committerDavid Galloway <david.galloway@ibm.com>
Mon, 12 Jan 2026 21:12:29 +0000 (16:12 -0500)
commitb15dc4f9e4b6ec540d86e1e575bd86b903e7ee30
tree6ef78bab6ac762e0829b46a88d4fcec245c98606
parente397109dc5c404e8a61fbe9503f9b59dc788c29b
task/install: extra_system_packages at the top level can be a list

Commit fc5a3197f22e ("task/install: allow both list and dicts for
extra_system_packages") introduced a regression for job definitions
where extra_system_packages at the top level (i.e. on the install
task itself) is a list.  For example

  overrides:
    install:
      ceph:
        flavor: default
        sha1: b7d57fefbec68934ae5e6e7d7c48ac09182397a5
      extra_system_packages:
      - pv

produces AssertionError on

  assert isinstance(b, dict)

in deep_merge() when it's called from _override_extra_system_packages().

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
teuthology/task/install/__init__.py
teuthology/test/task/test_install.py