]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ansible.git/commit
ceph-osd: fix fs.aio-max-nr sysctl condition
authorDimitri Savineau <dsavinea@redhat.com>
Wed, 6 Nov 2019 15:15:53 +0000 (10:15 -0500)
committerGuillaume Abrioux <gabrioux@redhat.com>
Thu, 7 Nov 2019 19:38:33 +0000 (20:38 +0100)
commitb47f7763fc0872484ce00b75b17ea97a71faa206
treea213467c020bfa8f1a0f2b585ba03aa348758265
parente8ed6655f3e5ce9e13216ec7663fe40f1197f9b7
ceph-osd: fix fs.aio-max-nr sysctl condition

[1] introduced a regression on the fs.aio-max-nr sysctl value condition.
The enable key isn't a boolean but a string because the expression isn't
evaluated.
This string output "(osd_objectstore == 'bluestore')" is always true
because item.enable condition only matches non empty string. So the
sysctl value was applyied for both filestore and bluestore backend.

[2] added the bool filter to the condition but the filter always returns
false on string and the sysctl wasn't applyed at all.

This commit fixes the enable key value by evaluating the value instead
of using the string.

[1] https://github.com/ceph/ceph-ansible/commit/08a2b58
[2] https://github.com/ceph/ceph-ansible/commit/ab54fe2

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
(cherry picked from commit ece46d33be566994d6ce799fdc4547299b352429)
roles/ceph-osd/tasks/system_tuning.yml