]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
mon/ConfigMonitor: kill improper assert
authorxie xingguo <xie.xingguo@zte.com.cn>
Thu, 21 Mar 2019 08:19:49 +0000 (16:19 +0800)
committerxie xingguo <xie.xingguo@zte.com.cn>
Fri, 22 Mar 2019 10:54:17 +0000 (18:54 +0800)
commitb4eb1f0ed8c5ef490884898816ee6e701cd95ab4
treed8a0a994bda6c849260769767ee40a5a7d4e314d
parent7b32361bd34fd8d4ab3bd22ae6672cc4ca1cc5f0
mon/ConfigMonitor: kill improper assert

otherwise it can be reliably triggerred by the following command:

  ceph config reset 0

There are two ways to fix this problem:
- add some more santicy checks and prevent user from passing in
  any kind of non-positive (not permitted) value
- kill the assert instead

Option 2 sounds to be the preferred choice for me since "0" in general
is the natural representation of "nothing" and hence could always
be used to revert everything to its default or initiative state.

But perhaps I am the only one?

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
src/mon/ConfigMonitor.cc