]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Stable cache keys on ingested SST files (#8669)
authorPeter Dillinger <peterd@fb.com>
Wed, 18 Aug 2021 18:32:00 +0000 (11:32 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Wed, 18 Aug 2021 18:33:03 +0000 (11:33 -0700)
commitb6269b078a58155e5dfe26d6af087ab10d5eba00
treeb1bd022b34b9cdac19f85d9474f5b6c9a0d8031a
parent2b367fa8cc58341ced2e5dae45396783143a6352
Stable cache keys on ingested SST files (#8669)

Summary:
Extends https://github.com/facebook/rocksdb/issues/8659 to work for ingested external SST files, even
the same file ingested into different DBs sharing a block cache.

Note: These new cache keys are currently only enabled when FileSystem
does not provide GetUniqueId. For now, they are typically larger,
so slightly less efficient.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8669

Test Plan: Extended unit test

Reviewed By: zhichao-cao

Differential Revision: D30398532

Pulled By: pdillinger

fbshipit-source-id: 1f13e2af4b8bfff5741953a69466e9589fbc23c7
db/db_block_cache_test.cc
db/db_impl/db_impl.cc
db/db_impl/db_impl.h
db/repair.cc
table/block_based/block_based_table_reader.cc
table/sst_file_writer.cc
util/defer.h