]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Handle "NotSupported" status by default implementation of Close() in … (#10127)
authorzczhu <>
Tue, 7 Jun 2022 16:49:31 +0000 (09:49 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Tue, 7 Jun 2022 16:49:31 +0000 (09:49 -0700)
commitb6de139df51c655691930f4dc669f218745aba11
tree6d8d62fd300a5b181d10a97399ac641638c7fd4c
parent3ee6c9baec6574433440018ecf58c0b05dc8b2e3
Handle "NotSupported" status by default implementation of Close() in … (#10127)

Summary:
The default implementation of Close() function in Directory/FSDirectory classes returns `NotSupported` status. However, we don't want operations that worked in older versions to begin failing after upgrading when run on FileSystems that have not implemented Directory::Close() yet. So we require the upper level that calls Close() function should properly handle "NotSupported" status instead of treating it as an error status.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/10127

Reviewed By: ajkr

Differential Revision: D36971112

Pulled By: littlepig2013

fbshipit-source-id: 100f0e6ad1191e1acc1ba6458c566a11724cf466
db/column_family.cc
db/db_impl/db_impl.cc
db/db_impl/db_impl.h
file/filename.cc