]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commit
projects / ceph-client.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 56b029d) | patch
net: dsa: mt7530: make some noise if register read fails
authorDaniel Golle <daniel@makrotopia.org>
Mon, 3 Apr 2023 01:17:19 +0000 (02:17 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 3 Apr 2023 09:13:00 +0000 (10:13 +0100)
commitb6f56cddb5f57a0b8da0ce582232a2f1933558c6
treeb286bfe7c1d9b7da4bc5508195038c60d8582ad4tree | snapshot
parent56b029ddac8eebdeb3d8a15c8aed71a1c62e4924commit | diff
net: dsa: mt7530: make some noise if register read fails

Simply returning the negative error value instead of the read value
doesn't seem like a good idea. Return 0 instead and add WARN_ON_ONCE(1)
so this kind of error will not go unnoticed.

Suggested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mt7530.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.