]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
mgr/cephadm: reformat ceph.deployment.service_spec import line
authorJohn Mulligan <jmulligan@redhat.com>
Thu, 25 May 2023 22:54:05 +0000 (18:54 -0400)
committerAdam King <adking@redhat.com>
Thu, 31 Aug 2023 17:35:15 +0000 (13:35 -0400)
commitb77587afff87c6ffcdda321f1e1269a9f6ce01ca
tree4573a140ac58e02183156c9b671adcee777f1f6f
parent364cbb1665f53f9918d332aeebe3b1407a2728d4
mgr/cephadm: reformat ceph.deployment.service_spec import line

Quoting https://peps.python.org/pep-0008/#maximum-line-length
```
The preferred way of wrapping long lines is by using Python’s
implied line continuation inside parentheses, brackets and braces. Long
lines can be broken over multiple lines by wrapping expressions in
parentheses. These should be used in preference to using a backslash for
line continuation.
```

I also think it is much more readable and is similar to the style
applied by automated code formatting tools like `black`.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit 3d7b9342383ab5d4a2c7a346d6982aea09ebc6f8)
src/pybind/mgr/cephadm/serve.py
src/pybind/mgr/cephadm/services/cephadmservice.py
src/pybind/mgr/cephadm/tests/test_cephadm.py
src/python-common/ceph/tests/test_service_spec.py