]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commit
dmaengine: idxd: Fix refcount underflow on module unload
authorYi Sun <yi.sun@intel.com>
Tue, 29 Jul 2025 15:03:13 +0000 (23:03 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 20 Aug 2025 17:29:58 +0000 (22:59 +0530)
commitb7cb9a034305d52222433fad10c3de10204f29e7
tree5191d2a3196d613ed73b5da2e5597eb47bb23ebf
parentf41c538881eec4dcf5961a242097d447f848cda6
dmaengine: idxd: Fix refcount underflow on module unload

A recent refactor introduced a misplaced put_device() call, resulting in a
reference count underflow during module unload.

There is no need to add additional put_device() calls for idxd groups,
engines, or workqueues. Although the commit claims: "Note, this also
fixes the missing put_device() for idxd groups, engines, and wqs."

It appears no such omission actually existed. The required cleanup is
already handled by the call chain:
idxd_unregister_devices() -> device_unregister() -> put_device()

Extend idxd_cleanup() to handle the remaining necessary cleanup and
remove idxd_cleanup_internals(), which duplicates deallocation logic
for idxd, engines, groups, and workqueues. Memory management is also
properly handled through the Linux device model.

Fixes: a409e919ca32 ("dmaengine: idxd: Refactor remove call with idxd_cleanup() helper")
Signed-off-by: Yi Sun <yi.sun@intel.com>
Tested-by: Shuai Xue <xueshuai@linux.alibaba.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Link: https://lore.kernel.org/r/20250729150313.1934101-3-yi.sun@intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/idxd/init.c