]> git.apps.os.sepia.ceph.com Git - xfsprogs-dev.git/commit
xfs_db: fix octal conversion logic
authorDarrick J. Wong <djwong@kernel.org>
Wed, 23 Nov 2022 17:09:17 +0000 (09:09 -0800)
committerCarlos Maiolino <cem@kernel.org>
Fri, 9 Dec 2022 09:18:19 +0000 (10:18 +0100)
commitb84d0823d5653391d8b2d4dcc8d1da40ebe41b28
treeacad16c1bf2ae3be5e5906f87ebedb61aebaedc4
parenta946664debbad130ae1b73058be9bc847623e7fd
xfs_db: fix octal conversion logic

Fix the backwards boolean logic here, which results in weird behavior.

# xfs_db -x -c /dev/sda
xfs_db> print fname
fname = "\000\000\000\000\000\000\000\000\000\000\000\000"
xfs_db> write fname "mo\0h5o"
fname = "mo\005o\000\000\000\000\000\000\000\000"
xfs_db> print fname
fname = "mo\005o\000\000\000\000\000\000\000\000"

Notice that we passed in octal-zero, 'h', '5', 'o', but the fs label is
set to octal-5, 'o' because of the incorrect loop logic.  -Wlogical-op
found this one.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
db/write.c