]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fix compaction_job_test
authorIgor Canadi <icanadi@fb.com>
Mon, 6 Jul 2015 18:14:08 +0000 (11:14 -0700)
committeragiardullo <agiardullo@fb.com>
Tue, 7 Jul 2015 19:35:36 +0000 (12:35 -0700)
commitbc672aefb37dfe7e8f74e7c27e60a21efc1bf81e
tree2ec55895a00978a73c493edd19559d4e73e58d90
parentb565228e1ef75b8192b2124e75237309f6b43acb
Fix compaction_job_test

Summary:
Two issues:
* the input keys to the compaction don't include sequence number.
* sequence number is set to max(seq_num), but it should be set to max(seq_num)+1, because the condition here is strictly-larger (i.e. we will only zero-out sequence number if the DB's sequence number is strictly greater than the key's sequence number): https://github.com/facebook/rocksdb/blob/master/db/compaction_job.cc#L830

Test Plan: make compaction_job_test && ./compaction_job_test

Reviewers: sdong, lovro

Reviewed By: lovro

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D41247
(cherry picked from commit 155ce60dafbc3841da73eedf0d9dc6c4fabd8404)
db/compaction_job_test.cc