]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
mgr/rbd_support: always parse interval and start_time in Schedules::remove()
authorIlya Dryomov <idryomov@gmail.com>
Tue, 25 Mar 2025 08:13:27 +0000 (09:13 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Tue, 25 Mar 2025 09:39:31 +0000 (10:39 +0100)
commitbcd676356231c97c8275e6c03becc2c58497f20d
tree37ca7ef0cef4c9c4ad3a1cf58560276533695e3f
parent538a5766d2d96399b411867a71dff2d12ea14952
mgr/rbd_support: always parse interval and start_time in Schedules::remove()

Commit 1b62447071a9 ("mgr/rbd_support: fix schedule remove") addressed
the issue that it was concerned with in a rather suboptimal way: instead
of moving the parsing of interval and start_time upfront to be able to
bail early, it wrapped from_string() constructors with try/finally and
left the conditional behavior in place.

Fixes: https://tracker.ceph.com/issues/70640
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
qa/workunits/rbd/cli_generic.sh
src/pybind/mgr/rbd_support/schedule.py