]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
cls/fifo: Fix race condition on `_prepare_new_head`
authorAdam C. Emerson <aemerson@redhat.com>
Wed, 2 Nov 2022 02:49:12 +0000 (22:49 -0400)
committerAdam C. Emerson <aemerson@redhat.com>
Mon, 9 Jan 2023 22:27:34 +0000 (17:27 -0500)
commitbf222906b01cbb9e8d55ae4685004a22cddcc138
tree57310a6c50b34672330419a4fade445b0a888d29
parentfcaa45d32d22653c6c8272a7a43af41bf3dc7e88
cls/fifo: Fix race condition on `_prepare_new_head`

First, make `_prepare_new_head` take the new head part number, so two
calls racing from the same push will attempt to create the same head.

Also remove the neorados FIFO since it doesn't have all the bug fixes
in the legacy version and will be rewritten in terms of `async_compose`
anyway.

Fixes: https://tracker.ceph.com/issues/57562
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
src/rgw/driver/rados/cls_fifo_legacy.cc
src/rgw/driver/rados/cls_fifo_legacy.h