]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Cleanup of ThreadStatusUtil structures should use the DB's reference
authorHerman Lee <herman@fb.com>
Thu, 30 Mar 2017 17:31:26 +0000 (10:31 -0700)
committerIslam AbdelRahman <tec@fb.com>
Wed, 12 Apr 2017 18:34:56 +0000 (11:34 -0700)
commitc0be8be0cffa92eb55f94cc4a88c3a2267ae101e
tree979fe04a46f7cb3954a6772d666271235edaf046
parent4fb65f9ea7696cf9793e90b0682ee8aa5f582b1d
Cleanup of ThreadStatusUtil structures should use the DB's reference

Summary:
instead of thread_local

The cleanup path for the rocksdb database might not have the
thread_updater_local_cache_ pointer initialized because the thread
executing the cleanup is likely not a rocksdb thread. This results in a
memory leak detected by Valgrind. The cleanup code path should use the
thread_status_updater pointer obtained from the DB object instead of a
thread local one.
Closes https://github.com/facebook/rocksdb/pull/2059

Differential Revision: D4801611

Pulled By: hermanlee

fbshipit-source-id: 407d7de
util/thread_status_util.cc