]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commit
common/rc: decouple xfs_io flink check from xfs_io -T check
authorAmir Goldstein <amir73il@gmail.com>
Sun, 6 May 2018 06:36:07 +0000 (09:36 +0300)
committerEryu Guan <guaneryu@gmail.com>
Fri, 11 May 2018 10:40:04 +0000 (18:40 +0800)
commitc29a70330fdf4f3ce4e7ba3a28e05fc45cf1a96b
tree8ef8769ba6ed1d584909207fd54e9d15a0cc734a
parent272ddcdd191e2979a3d03fd5b8e3dde7ef9233eb
common/rc: decouple xfs_io flink check from xfs_io -T check

The 3 tests that _require_xfs_io_command "flink", actually require
O_TMPFILE support and flink command, but the former is far unlikely
to be missing. The test btrfs/058 doesn't even use the flink
command.

When running these tests on a filesystem that does not support
O_TMPFILE (e.g. overlayfs) the result is not very infomative:

 generic/004 1s ... [not run] xfs_io flink failed (old kernel/wrong fs?)

Decouple the requirements for "flink" command and "-T" command line
flag and require the former explicitly in tests that use it.

As a result the report is now more informative:

 generic/004 1s ... [not run] O_TMPFILE is not supported

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Reviewed-by: Eryu Guan <guaneryu@gmail.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
common/rc
tests/btrfs/058
tests/generic/004
tests/generic/389