]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commit
irqchip/atmel-aic[5]: Fix incorrect lock guard conversion
authorEdgar Bonet <bonet@grenoble.cnrs.fr>
Thu, 14 Aug 2025 12:59:42 +0000 (14:59 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Sat, 23 Aug 2025 19:41:07 +0000 (21:41 +0200)
commitc2bac68067bba5edda09112c09f2f670792dcdc8
treebb7b399bad0210979111062e9e66b173df93fc3b
parent8f5ae30d69d7543eee0d70083daf4de8fe15d585
irqchip/atmel-aic[5]: Fix incorrect lock guard conversion

Commit b00bee8afaca ("irqchip: Convert generic irqchip locking to guards")
replaced calls to irq_gc_lock_irq{save,restore}() with
guard(raw_spinlock_irq).

However, in irq-atmel-aic5.c and irq-atmel-aic.c, the xlate callback is
used in the early boot process, before interrupts are initially enabled.
As its destructor enables interrupts, this triggers the warning in
start_kernel():

    WARNING: CPU: 0 PID: 0 at init/main.c:1024 start_kernel+0x4d0/0x5dc
    Interrupts were enabled early

Fix this by using guard(raw_spinlock_irqsave) instead.

[ tglx: Folded the equivivalent fix for atmel-aic ]

Fixes: b00bee8afaca ("irqchip: Convert generic irqchip locking to guards")
Signed-off-by: Edgar Bonet <bonet@grenoble.cnrs.fr>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/all/280dd506-e1fc-4d2e-bdc4-98dd9dca6138@grenoble.cnrs.fr
drivers/irqchip/irq-atmel-aic.c
drivers/irqchip/irq-atmel-aic5.c