]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
mgr/dashboard: Fix regression on table error handling
authorStephan Müller <smueller@suse.com>
Wed, 22 Jul 2020 14:00:32 +0000 (16:00 +0200)
committerStephan Müller <smueller@suse.com>
Wed, 29 Jul 2020 13:37:44 +0000 (15:37 +0200)
commitc4d1e95f094db31b24c13e71ad41370ec95fef41
tree8ff875df1fb5d3d0a4aa56d074870254b87afd7f
parent6be05fe77775ef92abef198fda85a7b01c2e9756
mgr/dashboard: Fix regression on table error handling

The regression was introduced by #35290 through the use of the new tab module
the pools and host listing got wrapped into the new usage, however they needed
to use the table as Viewchild and the table was static before, but it's now
dynamic. This resulted in an empty variable that wasn't filled with the
right table object. The calling of the ".reset()" was not possible
during an error case and produced an error in console trying to access
"reset" of undefined, by not calling "reset" the table get's stuck with an
rotating reload symbol.

Fixes: https://tracker.ceph.com/issues/46660
Signed-off-by: Stephan Müller <smueller@suse.com>
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/hosts.component.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-list/osd-list.component.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/services.component.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-list/pool-list.component.ts