]> git.apps.os.sepia.ceph.com Git - ceph-ansible.git/commit
mdss: do not make pg_num a mandatory params
authorGuillaume Abrioux <gabrioux@redhat.com>
Tue, 29 May 2018 07:18:08 +0000 (09:18 +0200)
committerGuillaume Abrioux <gabrioux@redhat.com>
Wed, 30 May 2018 14:20:34 +0000 (16:20 +0200)
commitc68126d6fdde8efbeb6e5c495a0147a34a5dfd0e
treeb26cb7717b5daf514b39a1d7b3db90561af8e7f5
parent34e646e767955024c9b186f9eaa61f809fe45af0
mdss: do not make pg_num a mandatory params

When playing ceph-mds role, mon nodes have set a fact with the default
pg num for osd pools, we can simply default to this value for cephfs
pools (`cephfs_pools` variable).

At the moment the variable definition for `cephfs_pools` looks like:

```
cephfs_pools:
  - { name: "{{ cephfs_data }}", pgs: "" }
  - { name: "{{ cephfs_metadata }}", pgs: "" }
```

and we have a task in `ceph-validate` to ensure `pgs` has been set to a
valid value.

We could simply avoid this check by setting the default value of `pgs`
to `hostvars[groups[mon_group_name][0]]['osd_pool_default_pg_num']` and
let to users the possibility to override this value.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1581164
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
group_vars/all.yml.sample
group_vars/rhcs.yml.sample
roles/ceph-defaults/defaults/main.yml
roles/ceph-validate/tasks/main.yml
tests/functional/centos/7/cluster/group_vars/all
tests/functional/centos/7/docker-collocation/group_vars/all
tests/functional/centos/7/docker/group_vars/all
tests/functional/ubuntu/16.04/cluster/group_vars/all