]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
xfs: remove redundant validation in xlog_recover_attri_commit_pass2
authorLong Li <leo.lilong@huawei.com>
Fri, 20 Mar 2026 02:11:30 +0000 (10:11 +0800)
committerCarlos Maiolino <cem@kernel.org>
Mon, 23 Mar 2026 10:00:08 +0000 (11:00 +0100)
commitc6c56ff975f046be25f527231a239e37920aca5e
tree45c4b284f7137bfbe4afc2a01abb82c659a2a23d
parentd72f2084e30966097c8eae762e31986a33c3c0ae
xfs: remove redundant validation in xlog_recover_attri_commit_pass2

Remove the redundant post-parse validation switch. By the time that
block is reached, xfs_attri_validate() has already guaranteed all name
lengths are non-zero via xfs_attri_validate_namelen(), and
xfs_attri_validate_name_iovec() has already returned -EFSCORRUPTED for
NULL names. For the REMOVE case, attr_value and value_len are
structurally guaranteed to be NULL/zero because the parsing loop only
populates them when value_len != 0. All checks in that switch are
therefore dead code.

Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Long Li <leo.lilong@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/xfs_attr_item.c