]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
rgw/multisite: Fix use-after-move in retry logic in logbacking
authorAdam Emerson <aemerson@redhat.com>
Tue, 4 Jun 2024 03:17:33 +0000 (23:17 -0400)
committerAdam Emerson <aemerson@redhat.com>
Fri, 10 Jan 2025 21:31:58 +0000 (16:31 -0500)
commitc9e9744e9faf145289526c72d53d46ab75a04f01
treedfe1a36f728257c47a3f1628ec7158c51f2b23e4
parentcb5801872d0df4b9358bfa749d2b421f5d15376c
rgw/multisite: Fix use-after-move in retry logic in logbacking

Fitting a retry loop around a call that took the lock changed the
logic to potentially have the lock be used after moving.

Thanks to Suyash Dongre suyashd999@gmail.com for finding it.

This patch also fixes a lock being held across an I/O operation.

Fixes: https://tracker.ceph.com/issues/66340
Signed-off-by: Adam Emerson <aemerson@redhat.com>
(cherry picked from commit 80cf2ca3b44246ad8f2e333182b3c8b1835a71f7)

Fixed: https://tracker.ceph.com/issues/68053

Signed-off-by: Adam Emerson <aemerson@redhat.com>
src/rgw/driver/rados/rgw_log_backing.cc