]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Add (& fix) some simple source code checks (#8821)
authorPeter Dillinger <peterd@fb.com>
Wed, 8 Sep 2021 04:18:21 +0000 (21:18 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Wed, 8 Sep 2021 04:19:27 +0000 (21:19 -0700)
commitcb5b851ff8cd2d3b2e8d15c449cd015d87e73bee
tree039eb4dce87f237f130b1c605cb684690ca13924
parent9308ff366cbbf35922528bfda7c0892c1ea320bc
Add (& fix) some simple source code checks (#8821)

Summary:
* Don't hardcode namespace rocksdb (use ROCKSDB_NAMESPACE)
* Don't #include <rocksdb/...> (use double quotes)
* Support putting NOCOMMIT (any case) in source code that should not be
committed/pushed in current state.

These will be run with `make check` and in GitHub actions

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8821

Test Plan: existing tests, manually try out new checks

Reviewed By: zhichao-cao

Differential Revision: D30791726

Pulled By: pdillinger

fbshipit-source-id: 399c883f312be24d9e55c58951d4013e18429d92
16 files changed:
.github/workflows/sanity_check.yml
Makefile
build_tools/check-sources.sh [new file with mode: 0755]
cache/cache_bench.cc
db_stress_tool/db_stress.cc
examples/compaction_filter_example.cc
include/rocksdb/memtablerep.h
include/rocksdb/system_clock.h
java/rocksjni/event_listener_jnicallback.cc
java/rocksjni/event_listener_jnicallback.h
memory/memkind_kmem_allocator.cc
memory/memkind_kmem_allocator.h
memory/memkind_kmem_allocator_test.cc
table/block_based/index_builder.cc
test_util/testharness.h
tools/db_bench.cc