]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fix WRITE_STALL start_time (#12147)
authorAkanksha Mahajan <43301668+akankshamahajan15@users.noreply.github.com>
Thu, 14 Dec 2023 21:45:06 +0000 (13:45 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 14 Dec 2023 21:45:06 +0000 (13:45 -0800)
commitcd577f605948894b51fbaab39d1df03a04dfd70f
tree3e30a64962b28a2f1c65eddb9bc9a0dea5d7a4b6
parent5502f0672908ce2c5891a3290bdfb57182435adb
Fix WRITE_STALL start_time (#12147)

Summary:
`Delayed` is set true in two cases. One is when `delay` is specified. Other one is in the `while` loop - https://github.com/facebook/rocksdb/blob/cd21e4e69d76ec4ec3b080c8cdae016ac2309cc5/db/db_impl/db_impl_write.cc#L1876
However start_time is not initialized in second case, resulting in time_delayed = immutable_db_options_.clock->NowMicros() - 0(start_time);

Pull Request resolved: https://github.com/facebook/rocksdb/pull/12147

Test Plan: Existing CircleCI

Reviewed By: cbi42

Differential Revision: D52173481

Pulled By: akankshamahajan15

fbshipit-source-id: fb9183b24c191d287a1d715346467bee66190f98
db/db_impl/db_impl_write.cc
unreleased_history/bug_fixes/fix_stall_counter.md [new file with mode: 0644]