]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
cmake: use ENABLE_SHARED instead of BUILD_SHARED_LIBS
authorKefu Chai <kchai@redhat.com>
Sat, 4 Jun 2016 01:50:00 +0000 (09:50 +0800)
committerKefu Chai <kchai@redhat.com>
Sat, 4 Jun 2016 04:57:19 +0000 (12:57 +0800)
commitcf9a42c7cc8c13f91724db3a44e45b3fca696446
tree1afd216ca04bf0e8db3ec0104ad7e82e20753de2
parent703e9c800cd7877078d2c76152f70dadd2a5430b
cmake: use ENABLE_SHARED instead of BUILD_SHARED_LIBS

we decided to drop the static libraries from the *-dev debian packages.
so no more tricky changes for supporting creating both libraries.

* partially revert 1dbfb26: s/BUILD_SHARED_LIBS/ENABLE_SHARED/
 - add_library() command use BUILD_SHARED_LIBS as the default library
   type, and all intermediate libraries should static ones. it would
   cause unnecessary confusion if some developer uses add_library() without
   specifying the library type, and ends up with a .so. so we use our
   own setting variables for specifying the type of user facing libraries.
* revert ac47440
 - the BUILD_SHARED_LIBS setting is also populated to the gmock libraries,
   which should be compiled as static ones. otherwise the unit tests will
   crash on exit.

Signed-off-by: Kefu Chai <kchai@redhat.com>
CMakeLists.txt
src/CMakeLists.txt
src/librbd/CMakeLists.txt