]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
cls/rgw: duplicate reshard checks in all cls_rgw write operations
authorCasey Bodley <cbodley@redhat.com>
Wed, 4 Sep 2024 20:25:51 +0000 (16:25 -0400)
committerCasey Bodley <cbodley@redhat.com>
Thu, 5 Sep 2024 17:23:41 +0000 (13:23 -0400)
commitd011c522bb171e70fc5782f1e7a71ce5f37e573f
tree51126353ebea0595223e0fef054c48bbe99e6633
parent658098b4799dcb5bcb17b865b1d7a88bbcc4eafa
cls/rgw: duplicate reshard checks in all cls_rgw write operations

with the addition of the reshard log, all write ops now have to read the
omap header themselves. this read duplicates the one in
cls_rgw_guard_bucket_resharding(), leading to a minor performance
regression

this commit prepares a long-term fix for this regression by duplicating
the the reshard check done by cls_rgw_guard_bucket_resharding() in each
write operation. this will allow the cls_rgw_guard_bucket_resharding()
calls to be removed from rgw two releases later when we can guarantee
that all OSDs are performing this check for all write operations

Signed-off-by: Casey Bodley <cbodley@redhat.com>
src/cls/rgw/cls_rgw.cc
src/cls/rgw/cls_rgw_client.h
src/cls/rgw/cls_rgw_types.h
src/rgw/rgw_common.h