]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commit
crypto: af_alg - Fix incorrect boolean values in af_alg_ctx
authorEric Biggers <ebiggers@kernel.org>
Wed, 24 Sep 2025 20:18:22 +0000 (13:18 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 24 Sep 2025 21:43:32 +0000 (14:43 -0700)
commitd0ca0df179c4b21e2a6c4a4fb637aa8fa14575cb
tree3424116be476c4bd1893c92ef5526029e4fb4594
parentea78c190810ecd2c9dfb6d22b52fc670a38e8836
crypto: af_alg - Fix incorrect boolean values in af_alg_ctx

Commit 1b34cbbf4f01 ("crypto: af_alg - Disallow concurrent writes in
af_alg_sendmsg") changed some fields from bool to 1-bit bitfields of
type u32.

However, some assignments to these fields, specifically 'more' and
'merge', assign values greater than 1.  These relied on C's implicit
conversion to bool, such that zero becomes false and nonzero becomes
true.

With a 1-bit bitfields of type u32 instead, mod 2 of the value is taken
instead, resulting in 0 being assigned in some cases when 1 was intended.

Fix this by restoring the bool type.

Fixes: 1b34cbbf4f01 ("crypto: af_alg - Disallow concurrent writes in af_alg_sendmsg")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/crypto/if_alg.h