]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Revert Ribbon starting level support from #8198 (#8212)
authorPeter Dillinger <peterd@fb.com>
Wed, 21 Apr 2021 02:45:08 +0000 (19:45 -0700)
committerakankshamahajan <akankshamahajan@fb.com>
Wed, 21 Apr 2021 03:59:01 +0000 (20:59 -0700)
commitd21b2a96997a1f669e30063ee97437dbcd676861
tree04f618edfa970c9d244feb3765d86968285bcc98
parent43aee721812d6d70f2eb9c36ea35cd7cbaccf5f3
Revert Ribbon starting level support from #8198 (#8212)

Summary:
This partially reverts commit 10196d7edc2fc5c03553c76acaf1337b5c7c1718.

The problem with this change is because of important filter use cases:
FIFO compaction and SST writer. FIFO "compaction" always uses level 0 so
would only use Ribbon filters if specifically including level 0 for the
Ribbon filter policy. SST writer sets level_at_creation=-1 to indicate
unknown level, and this would be treated the same as level 0 unless
fixed.

We are keeping the part about committing to permanent schema, which is
only changes to API comments and HISTORY.md.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8212

Test Plan: CI

Reviewed By: jay-zhuang

Differential Revision: D27896468

Pulled By: pdillinger

fbshipit-source-id: 50a775f7cba5d64fb729d9b982e355864020596e
HISTORY.md
db_stress_tool/db_stress_common.h
db_stress_tool/db_stress_gflags.cc
db_stress_tool/db_stress_test_base.cc
include/rocksdb/filter_policy.h
options/options_test.cc
table/block_based/filter_policy.cc
table/block_based/filter_policy_internal.h
tools/db_crashtest.py
util/bloom_test.cc