]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fixing endless loop if seeking to end of key with seq num 0
authorAndres Noetzli <andres.noetzli@gmail.com>
Thu, 6 Aug 2015 17:43:28 +0000 (10:43 -0700)
committerAndres Noetzli <andres.noetzli@gmail.com>
Thu, 6 Aug 2015 17:43:28 +0000 (10:43 -0700)
commitd7314ba7594f29db58eb3ccd5e16b53b98b5e7cd
tree5eff8b460762d666511dca47870040019fc6d78f
parent48e6e9aa82946c9cb91fecd47c67c59a40ceac69
Fixing endless loop if seeking to end of key with seq num 0

Summary:
When seeking to the last occurrence of a key with sequence number 0, db_iter
ends up in an endless loop because it seeks to type kValueTypeForSeek
which is larger than kTypeDeletion/kTypeValue. Added test case that triggers
the behavior.

Test Plan: make clean all check

Reviewers: igor, rven, anthony, yhchiang, sdong

Reviewed By: sdong

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D43653
db/db_iter.cc
db/db_iter_test.cc