]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Disable snapshot refresh feature when snap_refresh_nanos is 0 (#5724)
authorMaysam Yabandeh <myabandeh@fb.com>
Tue, 20 Aug 2019 18:38:15 +0000 (11:38 -0700)
committermyabandeh <myabandeh@fb.com>
Wed, 18 Sep 2019 21:39:45 +0000 (14:39 -0700)
commitdd757ffde0117af50ea22c295469389f84501f11
tree584df5a73a0d7cd964454697dbbffea23f135cad
parentfdc56e2b734ee35920acc1b6cd4e414f6269461d
Disable snapshot refresh feature when snap_refresh_nanos is 0 (#5724)

Summary:
The comments of snap_refresh_nanos advertise that the snapshot refresh feature will be disabled when the option is set to 0. This contract is however not honored in the code: https://github.com/facebook/rocksdb/pull/5278
The patch fixes that and also adds an assert to ensure that the feature is not used when the option  is zero.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5724

Differential Revision: D16918185

Pulled By: maysamyabandeh

fbshipit-source-id: fec167287df7d85093e087fc39c0eb243e3bbd7e
HISTORY.md
db/compaction_iterator.h
db/compaction_job_test.cc
db/db_impl_compaction_flush.cc