]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commit
xfstests: generic/193 runs tests in wrong location
authorDave Chinner <dchinner@redhat.com>
Fri, 7 Jun 2013 13:06:33 +0000 (23:06 +1000)
committerBen Myers <bpm@sgi.com>
Tue, 25 Jun 2013 19:53:59 +0000 (14:53 -0500)
commitdf58d55289d0a91947e3a3dcb64d1e923a6735d9
tree4e7d0a3ed397c3a2335c9031d8064df2df1cd228
parente2549c60dd44b4d00a82bbc4acc91e094544839f
xfstests: generic/193 runs tests in wrong location

generic/193 runs the test in $here - the root of the xfstests source
tree/installation. IOWs, it doesn't test the filesystem on either
the TEST_DIR or SCRATCH_MNT, and so it not testing the filesystem
we think it is testing. Bad. Fixing this is the majority of the
change - introducing $test_root and $test_user for the files with
different owners, and then redirecting error output and filtering
the output appropriately.

And then add checks that truncate clears the suid/sgid bits
appropriately, something that has never been tested on XFS (and
likely other filesystems) so will cause kernels between 3.1 and 3.9
to assert fail as Dave Jones has recently reported.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
tests/generic/193
tests/generic/193.out