]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commit
HID: intel-ish-hid: Increase ISHTP resume ack timeout to 300ms
authorZhang Lixu <lixu.zhang@intel.com>
Wed, 23 Jul 2025 01:31:32 +0000 (09:31 +0800)
committerJiri Kosina <jkosina@suse.com>
Tue, 12 Aug 2025 12:49:14 +0000 (14:49 +0200)
commitdfbd535db74df0343ca39670e06326d7aee8c8f4
treed97ce0f0d98fdb636fbba62dee08c0e0d68c3bc6
parenta7fc15ed629be89e51e09b743277c53e0a0168f5
HID: intel-ish-hid: Increase ISHTP resume ack timeout to 300ms

During s2idle suspend/resume testing on some systems, occasional several
tens of seconds delays were observed in HID sensor resume handling. Trace
analysis revealed repeated "link not ready" timeout errors during
set/get_report operations, which were traced to the
hid_ishtp_cl_resume_handler() timing out while waiting for the ISHTP
resume acknowledgment. The previous timeout was set to 50ms, which proved
insufficient on affected machines.

Empirical measurements on failing systems showed that the time from ISH
resume initiation to receiving the ISHTP resume ack could be as long as
180ms. As a result, the 50ms timeout caused failures.

To address this, increase the wait timeout for ISHTP resume ack from 50ms
to 300ms, providing a safer margin for slower hardware. Additionally, add
error logging when a timeout occurs to aid future debugging and issue
triage. No functional changes are made beyond the timeout adjustment and
improved error reporting.

Signed-off-by: Zhang Lixu <lixu.zhang@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/intel-ish-hid/ipc/pci-ish.c
drivers/hid/intel-ish-hid/ishtp-hid-client.c
drivers/hid/intel-ish-hid/ishtp/bus.c
drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h