]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
usb: core: don't power off roothub PHYs if phy_set_mode() fails
authorGabor Juhos <j4g8y7@gmail.com>
Wed, 18 Feb 2026 20:21:07 +0000 (21:21 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 11 Mar 2026 15:16:41 +0000 (16:16 +0100)
commite293015ba76eb96ce4ebed7e3b2cb1a7d319f3e9
treec2e0de3db161e9106043d8c4260d1bdef5a7d94d
parent1be3b77de4eb89af8ae2fd6610546be778e25589
usb: core: don't power off roothub PHYs if phy_set_mode() fails

Remove the error path from the usb_phy_roothub_set_mode() function.
The code is clearly wrong, because phy_set_mode() calls can't be
balanced with phy_power_off() calls.

Additionally, the usb_phy_roothub_set_mode() function is called only
from usb_add_hcd() before it powers on the PHYs, so powering off those
makes no sense anyway.

Presumably, the code is copy-pasted from the phy_power_on() function
without adjusting the error handling.

Cc: stable@vger.kernel.org # v5.1+
Fixes: b97a31348379 ("usb: core: comply to PHY framework")
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://patch.msgid.link/20260218-usb-phy-poweroff-fix-v1-1-66e6831e860e@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/phy.c