]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
workqueue: Better describe stall check
authorPetr Mladek <pmladek@suse.com>
Wed, 25 Mar 2026 12:34:18 +0000 (13:34 +0100)
committerTejun Heo <tj@kernel.org>
Wed, 25 Mar 2026 15:51:02 +0000 (05:51 -1000)
commite398978ddf18fe5a2fc8299c77e6fe50e6c306c4
tree17a507284a400d63f19fa33d11890980e3ea2942
parentc7f27a8ab9f2f43570f0725256597a0d7abe2c5b
workqueue: Better describe stall check

Try to be more explicit why the workqueue watchdog does not take
pool->lock by default. Spin locks are full memory barriers which
delay anything. Obviously, they would primary delay operations
on the related worker pools.

Explain why it is enough to prevent the false positive by re-checking
the timestamp under the pool->lock.

Finally, make it clear what would be the alternative solution in
__queue_work() which is a hotter path.

Signed-off-by: Petr Mladek <pmladek@suse.com>
Acked-by: Song Liu <song@kernel.org>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/workqueue.c