]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
osd/ECBackend.cc: Fix double increment of num_shards_repaired stat
authorBill Scales <bill_scales@uk.ibm.com>
Wed, 19 Jun 2024 08:36:06 +0000 (08:36 +0000)
committerBill Scales <bill_scales@uk.ibm.com>
Wed, 19 Jun 2024 09:36:10 +0000 (09:36 +0000)
commite618dc01a7a1bdfaa3e1a6fa2a9a9ac13eee11b8
tree80fc1583d8e77138221a41fbc695f96b55457c56
parent679f382ef3648bd7a98b83535e6fe04698d6a84d
osd/ECBackend.cc: Fix double increment of num_shards_repaired stat

Commit https://github.com/ceph/ceph/commit/deffa8209f9c0bd300cfdb54d358402bfc6e41c6 refactored
ECBackend::handle_recovery_push for Crimson but accidentally duplicated the code that increments
the num_shards_repaired OSD statistic.

This caused one of the QA tests to fail because the stat reported twice as much repair work
had been completed than expected:

qa/standalone/scrub/osd-scrub-repair.sh: TEST_repair_stats_ec: test 26 = 13

Fixes: https://tracker.ceph.com/issues/64437
Signed-off-by: Bill Scales <bill_scales@uk.ibm.com>
src/osd/ECBackend.cc