]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
mgr/dashboard: backend api tests: tasks.mgr.dashboard.test_osd.OsdTest failures
authorVolker Theile <vtheile@suse.com>
Tue, 6 Nov 2018 13:00:24 +0000 (14:00 +0100)
committerVolker Theile <vtheile@suse.com>
Wed, 7 Nov 2018 16:36:53 +0000 (17:36 +0100)
commite6f130d47023c24f8a9c742f145abd34d7320cd8
treeb4a0496d8c6cba031ec024c81bb6fef17437e1c3
parent59db1dc303e0c7ad40c7046407e699dd62bbf48c
mgr/dashboard: backend api tests: tasks.mgr.dashboard.test_osd.OsdTest failures

- Fix bug in Dashboard QA unit test framework. Don't set the application type header manually, this is done by the requests library if required.
- Enhance QA unit test helper: Print the response of the API request if it fails. This should help to identify the problem more easily.
- Fix bug in the OSD controller. A parameter needs to be converted to integer.
- Take care that the params of the request object are not modified.

The issue was introduced by PR https://github.com/ceph/ceph/pull/24475. The CherryPy json_in plugin disclosed the errorneous unit test helper implementation.

Fixes: https://tracker.ceph.com/issues/36708
Signed-off-by: Volker Theile <vtheile@suse.com>
qa/tasks/mgr/dashboard/helper.py
src/pybind/mgr/dashboard/controllers/osd.py
src/pybind/mgr/dashboard/tools.py