]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
test/librados_test_stub: unbreak selfmanaged_snap_rollback()
authorIlya Dryomov <idryomov@gmail.com>
Sun, 16 Jun 2024 18:40:31 +0000 (20:40 +0200)
committerIlya Dryomov <idryomov@gmail.com>
Sun, 23 Jun 2024 09:52:22 +0000 (11:52 +0200)
commite8b1aedc0a5b0d9a664c74dfe34c974a3f021a6a
treefafa673d3d8afc0ca78ad097f33094dd4bfbfc6b
parent103426118ecb05a8ca749eae969b0450de38452f
test/librados_test_stub: unbreak selfmanaged_snap_rollback()

After the rollback assert in TestGroup.add_snapshot{,PP} was made
meaningful in the previous commit, it fails in mock tests which means
that rollback has never been exercised properly...

While I confess to not following file->snap_id == CEPH_NOSNAP branch
especially given how file variable is shadowed, it's pretty clear that
get_snap_read() doesn't belong here -- the snapshot selected for reads
has nothing to do with rollback.  Replacing it with the rollback snap
ID makes sense of the other branches and makes the tests in question
pass.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 91a06323549c3c68aa56e79fec21d6a7dcb62cc9)
src/test/librados_test_stub/TestMemIoCtxImpl.cc