]> git.apps.os.sepia.ceph.com Git - linux-firmware.git/commit
Revert "copy-firmware: Support additional compressor options"
authorEmil Velikov <emil.l.velikov@gmail.com>
Sun, 22 Sep 2024 15:31:23 +0000 (16:31 +0100)
committerMario Limonciello <superm1@gmail.com>
Thu, 10 Oct 2024 14:33:32 +0000 (14:33 +0000)
commite8f8537768aaa8d991477155ac00f7826457515e
treea6cb7a876121ca3dfb49d1a097271661049c5466
parentee8c336ab3ab434908866c9a5e6dbbc555a80f39
Revert "copy-firmware: Support additional compressor options"

This reverts commit 2bad80e7edd3c0f84718545d9338c8edfed16513.

The commit effectively added accidental command injection, while it was aiming
to control the compression flags.

In practise you'd want to use ZSTD_CLEVEL and ZSTD_NBTHREADS for zstd. As
documented in zstd(1) it allows for up-to level 19, which is fine since the
kernel does not support higher levels.

Arch, Alpine and likely other distributions have been using this approach
since day one.

The other compressors like xz have equivalent.

Cc: Juerg Haefliger <juerg.haefliger@canonical.com>
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
copy-firmware.sh