]> git.apps.os.sepia.ceph.com Git - ceph-ansible.git/commit
ceph-osd: fix fs.aio-max-nr sysctl condition
authorDimitri Savineau <dsavinea@redhat.com>
Wed, 6 Nov 2019 15:15:53 +0000 (10:15 -0500)
committerGuillaume Abrioux <gabrioux@redhat.com>
Thu, 7 Nov 2019 12:51:48 +0000 (13:51 +0100)
commitece46d33be566994d6ce799fdc4547299b352429
treea86737fc574096ecec78fe3130d4fd44867d82c2
parent02df2ab5ea37ab7d9cd42b1a4d324515cb503677
ceph-osd: fix fs.aio-max-nr sysctl condition

[1] introduced a regression on the fs.aio-max-nr sysctl value condition.
The enable key isn't a boolean but a string because the expression isn't
evaluated.
This string output "(osd_objectstore == 'bluestore')" is always true
because item.enable condition only matches non empty string. So the
sysctl value was applyied for both filestore and bluestore backend.

[2] added the bool filter to the condition but the filter always returns
false on string and the sysctl wasn't applyed at all.

This commit fixes the enable key value by evaluating the value instead
of using the string.

[1] https://github.com/ceph/ceph-ansible/commit/08a2b58
[2] https://github.com/ceph/ceph-ansible/commit/ab54fe2

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
roles/ceph-osd/tasks/system_tuning.yml