]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commit
usb: typec: anx7411: fix OF node reference leaks in anx7411_typec_switch_probe()
authorJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Tue, 26 Nov 2024 01:49:09 +0000 (10:49 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Dec 2024 15:25:54 +0000 (16:25 +0100)
commitef42b906df5c57d0719b69419df9dfd25f25c161
treec2ba634e10adbedc4c64f899b338a376f02b5f0e
parent645d56e4cc74e953284809d096532c1955918a28
usb: typec: anx7411: fix OF node reference leaks in anx7411_typec_switch_probe()

The refcounts of the OF nodes obtained by of_get_child_by_name() calls
in anx7411_typec_switch_probe() are not decremented. Replace them with
device_get_named_child_node() calls and store the return values to the
newly created fwnode_handle fields in anx7411_data, and call
fwnode_handle_put() on them in the error path and in the unregister
functions.

Fixes: e45d7337dc0e ("usb: typec: anx7411: Use of_get_child_by_name() instead of of_find_node_by_name()")
Cc: stable@vger.kernel.org
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20241126014909.3687917-1-joe@pf.is.s.u-tokyo.ac.jp
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/anx7411.c