]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
fix memory leak in two_level_iterator
authorZhongyi Xie <xiez@fb.com>
Mon, 16 Apr 2018 00:19:57 +0000 (17:19 -0700)
committerMaysam Yabandeh <myabandeh@fb.com>
Mon, 16 Apr 2018 21:23:11 +0000 (14:23 -0700)
commitf2fd21fa6f5b7d59a08013ca877a687ec8a2e97f
tree1b76ae8622818d0afaab7c77543e32e26e431122
parent758527812c2893119da5851829f4b811fc1e343b
fix memory leak in two_level_iterator

Summary:
this PR fixes a few failed contbuild:
1. ASAN memory leak in Block::NewIterator (table/block.cc:429). the proper destruction of first_level_iter_ and second_level_iter_ of two_level_iterator.cc is missing from the code after the refactoring in https://github.com/facebook/rocksdb/pull/3406
2. various unused param errors introduced by https://github.com/facebook/rocksdb/pull/3662
3. updated comment for `ForceReleaseCachedEntry` to emphasize the use of `force_erase` flag.
Closes https://github.com/facebook/rocksdb/pull/3718

Reviewed By: maysamyabandeh

Differential Revision: D7621192

Pulled By: miasantreble

fbshipit-source-id: 476c94264083a0730ded957c29de7807e4f5b146
52 files changed:
db/column_family_test.cc
db/compact_files_test.cc
db/compaction_job_stats_test.cc
db/compaction_job_test.cc
db/corruption_test.cc
db/cuckoo_table_db_test.cc
db/db_compaction_test.cc
db/db_dynamic_level_test.cc
db/db_log_iter_test.cc
db/db_tailing_iter_test.cc
db/db_universal_compaction_test.cc
db/deletefile_test.cc
db/external_sst_file_test.cc
db/options_file_test.cc
db/plain_table_db_test.cc
db/prefix_test.cc
db/repair_test.cc
db/wal_manager_test.cc
db/write_callback_test.cc
env/io_posix.cc
table/block_based_table_reader.cc
table/cuckoo_table_builder_test.cc
table/cuckoo_table_reader_test.cc
table/two_level_iterator.cc
table/two_level_iterator.h
tools/db_bench_tool.cc
tools/db_stress.cc
tools/ldb_cmd_test.cc
tools/reduce_levels_test.cc
tools/sst_dump_test.cc
util/auto_roll_logger_test.cc
util/autovector_test.cc
util/delete_scheduler_test.cc
utilities/backupable/backupable_db_test.cc
utilities/blob_db/blob_db_test.cc
utilities/checkpoint/checkpoint_test.cc
utilities/column_aware_encoding_exp.cc
utilities/date_tiered/date_tiered_test.cc
utilities/document/document_db_test.cc
utilities/document/json_document_test.cc
utilities/env_timed_test.cc
utilities/lua/rocks_lua_test.cc
utilities/memory/memory_test.cc
utilities/object_registry_test.cc
utilities/options/options_util_test.cc
utilities/redis/redis_lists_test.cc
utilities/spatialdb/spatial_db_test.cc
utilities/table_properties_collectors/compact_on_deletion_collector_test.cc
utilities/transactions/optimistic_transaction_test.cc
utilities/transactions/transaction_test.cc
utilities/transactions/write_prepared_transaction_test.cc
utilities/ttl/ttl_test.cc