]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Don't attempt to use SecondaryCache on block_cache_compressed (#10944)
authorPeter Dillinger <peterd@fb.com>
Sat, 12 Nov 2022 01:35:53 +0000 (17:35 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Sat, 12 Nov 2022 01:35:53 +0000 (17:35 -0800)
commitf321e8fc98fd6871616cbc9cd109f9d30b0eb860
tree966f152a93eb66e7719bf00186c87427c0f9ab0c
parent5e8947057b251e65940ab7db8d23ab2f764fd59c
Don't attempt to use SecondaryCache on block_cache_compressed (#10944)

Summary:
Compressed block cache depends on reading the block compression marker beyond the payload block size. Only the payload bytes were being saved and loaded from SecondaryCache -> boom!

This removes some unnecessary code attempting to combine these two competing features. Note that BlockContents was previously used for block-based filter in block cache, but that support has been removed.

Also marking block_cache_compressed as deprecated in this commit as we expect it to be replaced with SecondaryCache.

This problem was discovered during refactoring but didn't want to combine bug fix with that refactoring.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/10944

Test Plan: test added that fails on base revision (at least with ASAN)

Reviewed By: akankshamahajan15

Differential Revision: D41205578

Pulled By: pdillinger

fbshipit-source-id: 1b29d36c7a6552355ac6511fcdc67038ef4af29f
HISTORY.md
cache/lru_cache_test.cc
include/rocksdb/table.h
table/block_based/block_based_table_builder.cc
table/block_based/block_based_table_reader.cc
table/block_based/block_like_traits.h
table/block_based/filter_block_reader_common.cc