]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commit
unmount: resume logging of stdout and stderr for filtering
authorDarrick J. Wong <djwong@kernel.org>
Mon, 3 Feb 2025 22:00:28 +0000 (14:00 -0800)
committerZorro Lang <zlang@kernel.org>
Tue, 18 Feb 2025 04:42:39 +0000 (12:42 +0800)
commitf43da58ef9369f2dbccadb4d85bb1651ec96fa90
tree604ce665e8d508106dcfa8df0fffbc3514ee125c
parentaf0f1090e24042baf74b62b7f47c1ad096416b3d
unmount: resume logging of stdout and stderr for filtering

There's a number of places where a test program calls a variant of
_unmount but then pipes the output through a _filter script or
something.  The new _unmount helper redirects stdout and stderr to
seqres.full, which means that those error messages (some of which are
encoded in the golden outputs) are suppressed.  This leads to test
regressions in generic/050 and other places, so let's resume logging.

This also undoes all the changes that removed /dev/null redirection of
unmount calls.

Cc: <fstests@vger.kernel.org> # v2024.12.08
Fixes: 4c6bc4565105e6 ("fstests: clean up mount and unmount operations")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Zorro Lang <zlang@kernel.org>
check
common/quota
common/rc
tests/generic/050
tests/generic/085
tests/generic/361
tests/generic/590
tests/generic/746
tests/xfs/149
tests/xfs/530