]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Attempt to deflake DBTestXactLogIterator.TransactionLogIteratorCorruptedLog (#8627)
authorLevi Tamasi <ltamasi@fb.com>
Tue, 10 Aug 2021 18:08:34 +0000 (11:08 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Tue, 10 Aug 2021 18:10:07 +0000 (11:10 -0700)
commitf63331ebaf3493fda342da9b0dd86d8ab6c1bbe0
treedef94cafc548957fdf7ef27d5a7585545c6c1e42
parent82b81dc8b5e5370d1c77c860da9b518b5a7681ad
Attempt to deflake DBTestXactLogIterator.TransactionLogIteratorCorruptedLog (#8627)

Summary:
The patch attempts to deflake `DBTestXactLogIterator.TransactionLogIteratorCorruptedLog`
by disabling file deletions while retrieving the list of WAL files and truncating the first WAL file.
This is to prevent the `PurgeObsoleteFiles` call triggered by `GetSortedWalFiles` from
invalidating the result of `GetSortedWalFiles`. The patch also cleans up the test case a bit
and changes it to using `test::TruncateFile` instead of calling the `truncate` syscall directly.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8627

Test Plan: `make check`

Reviewed By: akankshamahajan15

Differential Revision: D30147002

Pulled By: ltamasi

fbshipit-source-id: db11072a4ad8900a2f859cb5294e22b1888c23f6
db/db_log_iter_test.cc