]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
client: change "is_delay" parameter in check_caps to "no_delay"
authorJeff Layton <jlayton@redhat.com>
Wed, 9 Nov 2016 14:36:06 +0000 (09:36 -0500)
committerJeff Layton <jlayton@redhat.com>
Wed, 9 Nov 2016 14:36:06 +0000 (09:36 -0500)
commitf785f55b68ac121fcaddc93471432197a1a0dd3d
treea0fa0baa1c8a126aecfe0465c721f8a9e80bbf68
parent2130ea485b59440094afd142d324cd54b94bda98
client: change "is_delay" parameter in check_caps to "no_delay"

Currently, when "is_delay" is true, we send the caps immediately. When
it's false, we delay them. This seems backward to me and is highly
confusing.

Sage says:

"It's definitely confusing.  the call site that motivated the naming is
 the one from tick(), that passes true ... for the delayed flush that
 forces them to be sent but lots of other callers set it to true to avoid
 delaying. It could use a rename/cleanup."

Let's change the name to "no_delay" to indicate that the caller wants
to send caps immediately instead of delaying them.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
src/client/Client.cc
src/client/Client.h