]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
ceph: remove error return from ceph_process_folio_batch()
authorSam Edwards <cfsworks@gmail.com>
Mon, 26 Jan 2026 02:30:54 +0000 (18:30 -0800)
committerIlya Dryomov <idryomov@gmail.com>
Wed, 11 Feb 2026 16:52:50 +0000 (17:52 +0100)
commitfa589acaac08f1877185b5eb22d0985664536101
tree044695143024474fe518d55eaeec74cc594de074
parentcac190c7674fea71620d754ffcdaaeed7c551dbc
ceph: remove error return from ceph_process_folio_batch()

Following an earlier commit, ceph_process_folio_batch() no longer
returns errors because the writeback loop cannot handle them.

Since this function already indicates failure to lock any pages by
leaving `ceph_wbc.locked_pages == 0`, and the writeback loop has no way
to handle abandonment of a locked batch, change the return type of
ceph_process_folio_batch() to `void` and remove the pathological goto in
the writeback loop. The lack of a return code emphasizes that
ceph_process_folio_batch() is designed to be abort-free: that is, once
it commits a folio for writeback, it will not later abandon it or
propagate an error for that folio. Any future changes requiring "abort"
logic should follow this invariant by cleaning up its array and
resetting ceph_wbc.locked_pages appropriately.

Signed-off-by: Sam Edwards <CFSworks@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
fs/ceph/addr.c