]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commit
xfs/818: fix some design issues
authorDarrick J. Wong <djwong@kernel.org>
Fri, 21 Mar 2025 21:28:26 +0000 (14:28 -0700)
committerZorro Lang <zlang@kernel.org>
Fri, 28 Mar 2025 01:05:05 +0000 (09:05 +0800)
commitfaa0190b363deab4bc2517aa3ee6f6a2c2f2f29d
tree84ac3e8cf244356c13eaeea02b2ea04a52dbd6f5
parenteff1baf42a79c5650b857108412d1dcc0c54e537
xfs/818: fix some design issues

While QA'ing zoned filesystem support, I discovered some design errors
in this test:

1) Since we're test formatting a sparse file on an xfs filesystem,
there's no need to play games with optimal device size; we can create
a totally sparse file that's the same size as SCRATCH_DEV.

2) mkfs.xfs cannot create realtime files, so if it fails with that,
there's no need to continue the test.

3) If mkfs -p fails for none of the proscribed reasons, it should exit
the test.  The final cat $tmp.mkfs will take care of tweaking the golden
output to register the test failure for further investigation.

Cc: fstests@vger.kernel.org # v2025.03.09
Fixes: 6d39dc34e61e11 ("xfs: test filesystem creation with xfs_protofile")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Zorro Lang <zlang@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Zorro Lang <zlang@kernel.org>
tests/xfs/818