]> git-server-git.apps.pok.os.sepia.ceph.com Git - xfsprogs-dev.git/commit
xfs_scrub_all: fix broken command line string array construction
authorDarrick J. Wong <djwong@kernel.org>
Thu, 4 Jun 2026 06:04:52 +0000 (23:04 -0700)
committerAndrey Albershteyn <aalbersh@kernel.org>
Thu, 11 Jun 2026 10:26:04 +0000 (12:26 +0200)
commitff0aeb2332002d9fa514364af1b2cd40d97e0eb4
tree8e7bc6de7807305d1c1d37f8dc6f0b258ccd996d
parentde2bc2763b532ca5f88b60d1c452a5a228785fd3
xfs_scrub_all: fix broken command line string array construction

In scrub_subprocess::__init__(), we construct cmd as an array of strings
to be passed (eventually) to exec.  Unfortunately, adding a string to an
array of strings doesn't do what you'd think in Python:

>>> x = ['moo', 'cow']
>>> x += '-x'
>>> x
['moo', 'cow', '-', 'x']

Fix this problem, which Codex has sharp enough eyes to catch.

Cc: linux-xfs@vger.kernel.org # v6.10.0
Fixes: a290edcfa0a391 ("xfs_scrub_all: encapsulate all the subprocess code in an object")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Andrey Albershteyn <aalbersh@kernel.org>
scrub/xfs_scrub_all.py.in