]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ansible.git/commit
modules: Add _info modules mergify/bp/stable-8.0/pr-7624 7628/head
authorTeoman ONAY <tonay@ibm.com>
Wed, 20 Nov 2024 15:06:08 +0000 (16:06 +0100)
committerTeoman ONAY <tonay@ibm.com>
Wed, 19 Mar 2025 10:08:14 +0000 (11:08 +0100)
commit6d6e600d2ff80c538ab4a2e42f82b9958b1182a6
tree04a5c09115c73f6f72cf943b6fd565f64827b97e
parent35131407e9858cc168baa1590f236c092336d0e3
modules: Add _info modules

Validate modules test fails with:

Argument state includes get, list or info as a choice.
Functionality should be in an _info or (if further conditions apply) _facts module.

on modules ceph_crush_rule and ceph_key

With Ansible 2.8 and onwards best practice requires that modules
gathering info to be put in a separate module named _info[1]

[1]https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_general.html#creating-an-info-or-a-facts-module

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit a1f65bbd35ef4ef78c868d444ccdd32282db4457)
22 files changed:
infrastructure-playbooks/ceph-keys.yml
infrastructure-playbooks/cephadm-adopt.yml
library/ceph_crush_rule.py
library/ceph_crush_rule_info.py [new file with mode: 0644]
library/ceph_key.py
library/ceph_key_info.py [new file with mode: 0644]
roles/ceph-client/tasks/pre_requisite.yml
roles/ceph-crash/tasks/main.yml
roles/ceph-exporter/tasks/main.yml
roles/ceph-facts/tasks/get_def_crush_rule_name.yml
roles/ceph-mds/tasks/common.yml
roles/ceph-mgr/tasks/common.yml
roles/ceph-mon/tasks/deploy_monitors.yml
roles/ceph-nfs/tasks/pre_requisite_container.yml
roles/ceph-nfs/tasks/pre_requisite_non_container.yml
roles/ceph-osd/tasks/common.yml
roles/ceph-osd/tasks/crush_rules.yml
roles/ceph-rbd-mirror/tasks/configure_mirroring.yml
roles/ceph-rgw/tasks/common.yml
roles/ceph-rgw/tasks/pre_requisite.yml
tests/library/test_ceph_crush_rule.py
tests/library/test_ceph_key.py